0bCdian / Waypaper-Engine

A wallpaper setter with playlist functionality!
GNU General Public License v3.0
165 stars 0 forks source link

Sends the notification twice #18

Closed Heyian closed 2 months ago

Heyian commented 2 months ago

I've testing this with swaync and mako and it seems waypaper-engine is sending the notification twice. I see 2 pids in the dbus-notifications interface.

Here's the output of dbus-monitor --session "type='method_call',interface='org.freedesktop.Notifications'":

signal time=1715694384.029922 sender=org.freedesktop.DBus -> destination=:1.189 serial=2 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameAcquired
   string ":1.189"
signal time=1715694384.029958 sender=org.freedesktop.DBus -> destination=:1.189 serial=4 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameLost
   string ":1.189"
method call time=1715694385.923486 sender=:1.190 -> destination=:1.188 serial=7 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=GetServerInformation
method call time=1715694385.923587 sender=:1.190 -> destination=:1.188 serial=8 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=GetServerInformation
method call time=1715694385.923703 sender=:1.190 -> destination=:1.188 serial=9 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=Notify
   string "Waypaper Engine"
   uint32 0
   string "/home/mafavreau/.waypaper_engine/images/nbplopes_fileUsersnbplopesDownloadsRISE20EDIT.png_5b1683e6-3ca3-4aaa-955e-97ffcd6c1f4d-topaz-high fidelity v2-7680w.jpeg"
   string "Waypaper Engine"
   string "Setting image: nbplopes_fileUsersnbplopesDownloadsRISE20EDIT.png_5b1683e6-3ca3-4aaa-955e-97ffcd6c1f4d-topaz-high fidelity v2-7680w.jpeg"
   array [
   ]
   array [
      dict entry(
         string "urgency"
         variant             byte 0
      )
      dict entry(
         string "sender-pid"
         variant             int64 68195
      )
   ]
   int32 2000
method call time=1715694385.970909 sender=:1.193 -> destination=:1.188 serial=7 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=GetServerInformation
method call time=1715694386.046041 sender=:1.193 -> destination=:1.188 serial=8 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=GetServerInformation
method call time=1715694386.047391 sender=:1.193 -> destination=:1.188 serial=9 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=Notify
   string "Waypaper Engine"
   uint32 0
   string "/home/mafavreau/.waypaper_engine/images/nbplopes_fileUsersnbplopesDownloadsRISE20EDIT.png_5b1683e6-3ca3-4aaa-955e-97ffcd6c1f4d-topaz-high fidelity v2-7680w.jpeg"
   string "Waypaper Engine"
   string "Setting image: nbplopes_fileUsersnbplopesDownloadsRISE20EDIT.png_5b1683e6-3ca3-4aaa-955e-97ffcd6c1f4d-topaz-high fidelity v2-7680w.jpeg"
   array [
   ]
   array [
      dict entry(
         string "urgency"
         variant             byte 0
      )
      dict entry(
         string "sender-pid"
         variant             int64 68206
      )
   ]
   int32 2000
0bCdian commented 2 months ago

Mmmm, that's weird, what do the pid's correspond to? Also, when does this happen? If an image is set via the daemon, or via the gui? Also, which version are you using? are you on latest git or the normal package. I'll get to it as soon as possible.

Heyian commented 2 months ago

It seems to only happen with the daemon when it changes the wallpapers with the timer and with the command waypaper-engine next-image

Doesn't happen if I double-click an image in the gui.

I'm on version 2.0.0.r12.231eabd-1, using the waypaper-engine-git AUR package. I'm pretty sure I am current, I rebuild it this morning. (This isn't new though, it's been happening for a while but I took time to write an issue this morning)

As for what the pid's correspond to, I'm trying to get to it but I'm not having any success...

Heyian commented 2 months ago

Forget it, I had an issue on my side. I completely reinstalled by deleting ~/.waypaper-engine and ~/.config/waypaper-engine and I only receive a single notification now. I hope you haven't worked on the issue so far...

0bCdian commented 2 months ago

No probs! I was looking into this but couldn't really replicate it. I'll try to figure out what could have happened, but I'm glad the issue is gone!