search

0bCdian / Waypaper-Engine

A wallpaper setter with playlist functionality!
GNU General Public License v3.0
165 stars 0 forks source link

Adding a directory only adds 2 images #6

Closed ryphon closed 5 months ago

ryphon commented 5 months ago

Maybe it's related to my file picker, but for some reason in the last couple days, when I click "Add Images from Directory", and add a directory with some 10-15 images, I'm only getting the first two alphanumerically.

Hyprland, Arch, Kernel 6.7 etc. I honestly don't know what I've changed since it last worked, been doing... a lot of customizations.

Any thoughts? I think it's GTK related, and something about the File Picker, but not sure where to dig in to actually figure out why it broke for wpe.

0bCdian commented 5 months ago

Hi! I have been able to reproduce this, I'll look into it and get back as soon as possible when I have the solution. This seems like a regression of sorts, not sure if related with the electron version or what, but I'll keep you updated!

ryphon commented 5 months ago

Love it, thanks. Thought I was going crazy.

0bCdian commented 5 months ago

I found the bug, for some reason fs.readdir and fs.readdirSync are broken while using {recursive:true} in current versions of electron, so I'm going to test further and open an issue there. In the meantime I'm rewriting some of the logic when searching recursively through directories and working around some potential bugs that could arise in certain situations like a subdirectory image having the same name as an image above and so on, I guess that I will be done later today (It's kind late here on CET time) and push a new patch version fixing this issue.

0bCdian commented 5 months ago

Should be fixed in 01d4a335de5eadddbac95686fd03a1bcbceef726 , I will push the new version to the aur, update in a few minutes and let me know if the issue is fixed to close it :)

ryphon commented 5 months ago

Haven't yet seen the update in the aur, still 1.2.7-1, will keep my eyes open though.

0bCdian commented 5 months ago

Sorry about that, had to go out and didn't update the aur package, now it should be actually updated!

ryphon commented 5 months ago

Yep, that worked! Thanks!