0x3F-Lab / love-letters

Agile Web Dev Project
4 stars 0 forks source link

45 post interactivity #53

Closed Mitan4E closed 2 months ago

Mitan4E commented 2 months ago

To do:

(When making browse.html I was not aware of postcard.html that Alex had made, so I moved functionality from postcard.html into browse.html which can be put back into postcard.html to make the file look clean)

AkhilG4 commented 2 months ago

Im unsure if this is on my end, but you cannot see the reply a person makes regardless of if you press view replies or not after making a reply unless the page is refreshed entirely.

I feel like once a reply is made, it should automatically refresh the page as the scrolled position you are in stays the same when you refresh the page.

Furthermore we can also make it so that once a reply is made, that reply is vissible when they press the submit reply

Alex-Hawking commented 2 months ago

View reply and replies functionality works well.

However should be able to click users name in reply to view profile.

AkhilG4 commented 2 months ago

Check out the changes that I have done and let me know how it looks (Detailed message in commit)

Summary:

Still need to be done:

AkhilG4 commented 2 months ago

Yeah I guess commenting anonymously would be good but I feel like that can easily be abused?

AkhilG4 commented 2 months ago

Forgot to change the JS file. Should be working properly now

Mitan4E commented 2 months ago

Yes we should allow anonymouse replies. Posting itself can also be abused so I dont think it will matter that replying can, we'll figure out a way to handle what happens to annoying anonymouse replyers/posters

Mitan4E commented 2 months ago

The changes you made work great, just tested them out. Happy to merge this into development now.

Mitan4E commented 2 months ago

Good fix, the error message is displayed correctly if a user tries to reply without being logged in. Also we can sort out the migrate stuff in the next PR.