fix: Remove caller ID workaround for root contexts

0xPolygonMiden / miden-base

Core components of the Polygon Miden rollup

MIT License

68 stars 41 forks source link

fix: Remove caller ID workaround for root contexts #857

Closed igamigo closed 2 weeks ago

igamigo commented 3 weeks ago

Closes #851 Also refactors tests to check against VM error codes. This resulted in some tests being slightly modified to account for things that were out of place (eg, some create_notes did not have parameters up to date and the process.is_err() would make the tests pass anyway). Also adds some missing kernel errors to the kernel errors array.

igamigo commented 3 weeks ago

This is also possibly a breaking change (under testing at least), but I'm not sure we need to add a changelog line for this

igamigo commented 3 weeks ago

Some tests were failing with incorrect errors (missing note types in note-creation scripts, etc.). Changing this PR to draft until all are fixed.

phklive commented 2 weeks ago

Looking into the PR, I think this is the right solution, though previously when trying this method we hit limitations with the assembler erroring out on PhantomCalls did you face similar issues?