search

0xPolygonMiden / miden-base

Core components of the Polygon Miden rollup
MIT License
68 stars 41 forks source link

fix: Use `alloc`'s `Arc` instead of the standard library #868

Closed igamigo closed 2 weeks ago

igamigo commented 2 weeks ago

Looks good! Thank you! (not sure why CI missed it in the first place - i guess we are not running tests in no-std?)

Yeah, more specifically attempting to compile no-std with the testing flag will fail. I debated adding the flag to the make target but decided not to for this PR at least.

bobbinth commented 2 weeks ago

Looks good! Thank you! (not sure why CI missed it in the first place - i guess we are not running tests in no-std?)

Yeah, more specifically attempting to compile no-std with the testing flag will fail. I debated adding the flag to the make target but decided not to for this PR at least.

Makes sense! I do think we should add it though (in a different PR).