search

0xPolygonMiden / miden-base

Core components of the Polygon Miden rollup
MIT License
73 stars 45 forks source link

Separate `mock_library` into both `mock_wallet` and `mock_faucet` #878

Open phklive opened 2 months ago

phklive commented 2 months ago

Feature description

We have built 1 account interface that exports many procedures related to faucets, wallets, dummy, and more.

We should create 2 different interfaces that would be similar to how accounts would be created by a user.

Goal: Split mock_library into both mock_wallet and mock_faucet for testing

https://github.com/0xPolygonMiden/miden-base/blob/76a6635593ca168eda4517061ee0b4b845ad1c0f/objects/src/testing/account_code.rs#L41-L126

Why is this feature needed?

Splitting a monolithic account into 2 account interfaces with sensible procedures

phklive commented 2 months ago

Related to @bobbinth comment here: https://github.com/0xPolygonMiden/miden-base/pull/875#discussion_r1761807206