search

0xPolygonMiden / miden-base

Core components of the Polygon Miden rollup
MIT License
73 stars 45 forks source link

feat: replace `RefCell` with `Arc + RwLock` in `RemoteTransactionProver` #956

Closed tomyrd closed 2 weeks ago

tomyrd commented 2 weeks ago

To make the remote prover Send + Sync we need to remove the internal use of RefCell

igamigo commented 2 weeks ago

In general this looks good to me, but is this Arc still needed in the context of the client?

tomyrd commented 2 weeks ago

is this Arc still needed in the context of the client?

It's needed to be able to derive the Clone trait. If we don't need it maybe I can remove it.

tomyrd commented 2 weeks ago

I removed the Arc along with the Clone trait. The remote prover is already wrapped with an Arc in the client so it didn't need the trait.

SantiagoPittella commented 2 weeks ago

Sounds like the best option, to let the client/user choose better to add an Arc or not.