0xpatrickdev / agoric-vault-collateral-proposal

CoreEval Proposal and Permits for Inter Vault Collateral Type
0 stars 3 forks source link

vault addCollateral proposal updates #11

Closed 0xpatrickdev closed 1 year ago

0xpatrickdev commented 1 year ago

Reproducable Bundles:

I am working off of this: https://github.com/Agoric/agoric-sdk/compare/master...0xpatrickdev:agoric-sdk:pc/statom-vault-proposal

What was added

What is missing

Testing Status

I included ibc/toystatom in all the places that have ibc/toyatom in cosmic-swingset/Makefile, and this enables me to access test statom1 in the repl and other wallets.

I am (seemingly) able to submit oracles prices using the agops cli, but am getting a maxDebtFor called before a collateral quote was available error when opening an stATOM vault. This error occurs when storedCollateralQuote is undefined, so it seems I may be missing a step. Oracle prices must be sent from 2-3 addresses/operators, before the price registers. Once I included this in the flow, things are working as expected 🎉

image image
dckc commented 1 year ago

This is good progress. Several of the fixes look good.

If they were in their own PR(s), I would approve them, but I'm not sure what to do with this whole PR.