feat(denom): update to stATOM

0xpatrickdev / agoric-vault-collateral-proposal

CoreEval Proposal and Permits for Inter Vault Collateral Type

0 stars 3 forks source link

Closed 0xpatrickdev closed 1 year ago

0xpatrickdev commented 1 year ago

[x] change STATOM1 to STATOM, and use ibc/49C630713B2AB60653F76C0C58D43C2A64956803B4D422CACB6DD4AD016ED846 denom
[x] uses stATOM for displayName. The asset keyword ~~and brand~~ must begin with an uppercase letter, so STATOM is used

0xpatrickdev commented 1 year ago

@dckc I can't tag you as a reviewer until you join as a collaborator (invite just sent). Feel free to comment in lieue of approval!

dckc commented 1 year ago

The asset keyword and brand must begin with an uppercase letter, so STATOM is used

strictly speaking, only keywords have to start with uppercase. But somewhere in this code, we're lazy and re-use a brand name for a keyword. sigh

for follow-up, see #16