Closed dckc closed 1 year ago
possible solution:
I incorporated the changes here, as some of your other relevant PR's were not merged in yet:
Preliminary testing is showing a Error: keyword "stATOM" must be an ascii identifier starting with upper case.
is still being thrown:
GitHubmonorepo for the Agoric Javascript smart contract platform - Comparing pc/statom-vault-proposal...pc/statom-vault-proposal-issuerName · 0xpatrickdev/agoric-sdk
GitHubCoreEval Proposal and Permits for Inter Vault Collateral Type - Comparing main...feat/brand-issuer-name · 0xpatrickdev/agoric-vault-collateral-proposal
Thanks a bunch for testing.
Looks like we have more keyword/issuerName conflation in provisionPool. :-/
await zcf.saveIssuer(desc.issuer, desc.issuerName);
https://github.com/Agoric/agoric-sdk/blob/mainnet1B/packages/vats/src/provisionPoolKit.js#L347
re provisionPool, I have an idea. It's in https://github.com/Agoric/agoric-sdk/pull/8229 as 2b75c1ba1
. Try it out please?
the provisionPool bug isn't critical path to stATOM: the provisoinPool only needs to track assets that it can trade via a PSM.
In #15
stATOM
is used forproposedName
, but "The asset keyword must begin with an uppercase letter, soSTATOM
is used".Unfortunately, the
keyword
is used in more places than it should be; in particular, inagoricNames
.