0xpatrickdev / agoric-vault-collateral-proposal

CoreEval Proposal and Permits for Inter Vault Collateral Type
0 stars 3 forks source link

open vault on local chain: collateral quote? #8

Closed dckc closed 1 year ago

dckc commented 1 year ago

We should be sure actually creating a vault works on a local chain before trying it on devnet.

I suspect #2 and #3 make it impossible to actually create a vault using the collateral established by the proposal so far.

dckc commented 1 year ago

The "testing status" and "what is missing" notes in #11 look like work that's relevant here.

I am (seemingly) able to submit oracles prices using the agops cli, but am getting a maxDebtFor called before a collateral quote was available error when opening an stATOM vault. This error occurs when storedCollateralQuote is undefined, so it seems I may be missing a step.

dckc commented 1 year ago

Note "minSubmissionCount": 3 in decentral-devnet-config.json. Did you submit from 3 of the oracleAddresses?

In our testing, we have a little pushPrice shell function. But I think it assumes "minSubmissionCount": 2.

Hm. That config file also has "initialPrice": 12.34, which means it shouldn't be necessary to push a price before opening a vault at all.

Which config file are you/we using?

0xpatrickdev commented 1 year ago

Thanks Dan, changing minSubmissionCount to 2 and configuring a second oracle address to test with did the trick! I think with #11 we can mark this closed