search

17teen / Discord-Bladee-Server-Anti-Nuker

Archived Till A New Release Comes Out.
62 stars 72 forks source link

Make this better #3

Closed NotII closed 3 years ago

NotII commented 3 years ago

1) Why is there a JSON database, JSON databases are prone to corruption? 2) Your command handling is complete ass, you do realise you can check folders within a directory 3) Why are you using String.Raw, you can simple do:

console.log(`
                            ██████╗ ██╗      █████╗ ██████╗ ███████╗███████╗   
                            ██╔══██╗██║     ██╔══██╗██╔══██╗██╔════╝██╔════╝   
                            ██████╔╝██║     ███████║██║  ██║█████╗  █████╗     
                            ██╔══██╗██║     ██╔══██║██║  ██║██╔══╝  ██╔══╝     
                            ██████╔╝███████╗██║  ██║██████╔╝███████╗███████╗██╗
                            ╚═════╝ ╚══════╝╚═╝  ╚═╝╚═════╝ ╚══════╝╚══════╝╚═╝

                                  Anti Nuke | 7teen | Author: ${author}`)

4) Node LTS is not required, you can use both LTS and the current version 5) Your function backup should handle variables, never mind that you don't even require a function for that. 6) "Commando Structure" You don't even have the commando package. 7) The JSON structure switches between naming schemes try sticking to one naming scheme:

                 const data = {
                    guildID: ID,
                    guildName: Name,
                    Data: {
                        Owner: guild.owner.user.tag,
                        OwnerID: guild.ownerID,
                        WhiteListedUserIDs: [],
                        WhiteListedUsers: [],
                        BlackListedUserIDs: [],
                        BlackListedUsers: [],
                        TrustListedUserIDs: [],
                        TrustListedUsers: [],
                    }

Do not take this as hate it is criticism, which you can use to learn from