Closed imperugo closed 5 years ago
Looking the code here https://github.com/2020IP/TwentyTwenty.Storage/blob/74960b8bcbcc49f8ba46b6da7b3e31235f4c25bb/src/TwentyTwenty.Storage.Amazon/AmazonStorageProvider.cs#L244-L281 it seems the SAS url generate for S3 is ignoring the ServerSideEncryptionMethod.
Probably should be something like:
var request = new GetPreSignedUrlRequest { ServerSideEncryptionMethod = new ServerSideEncryptionMethod(_serverSideEncryptionMethod), };
Doesn't it?
@imperugo Yeah, I believe you are right. Want to put in a PR for that?
Of course. I'll do that
Done https://github.com/2020IP/TwentyTwenty.Storage/pull/24
Looking the code here https://github.com/2020IP/TwentyTwenty.Storage/blob/74960b8bcbcc49f8ba46b6da7b3e31235f4c25bb/src/TwentyTwenty.Storage.Amazon/AmazonStorageProvider.cs#L244-L281 it seems the SAS url generate for S3 is ignoring the ServerSideEncryptionMethod.
Probably should be something like:
Doesn't it?