Local provider: store metadata file with custom metadata

2020IP / TwentyTwenty.Storage

A cross-cloud storage abstraction

Other

100 stars 26 forks source link

Closed nover closed 3 years ago

nover commented 3 years ago

This PR will:

add System.Text.Json for working with json data
update UpdateBlobProperties* to store a filename-meta.json file with the content from passed BlobProperties
update GetBlobDescriptor* and List to merge "guessed" metadata with a stored metadata file
update GetBlobDescriptor* to also return the Metadata:dictionary<string,string> if stored in the metadata file
update delete/copy/move operations to work on stored metadata
refactor some internals to reduce code-duplication

Closes #33

nover commented 3 years ago

@ericgreenmix any chance of getting this reviewed and merged? :)

ericgreenmix commented 3 years ago

Yes, sorry for the delay. Been very busy this past week. I will try to get to this in the next day

nover commented 3 years ago

@ericgreenmix

No problems, I know about the busy days my self :) your suggestions have been fixed and squashed into the original commit.

As for the failing Azure tests, I believe it's because I'm creating a PR from a fork. I'm having similar problems on some of my repositories - Appveyor does not hand out secrets to PR builds from forks, as it would allow malicious code to steal them. https://help.appveyor.com/discussions/questions/46970-unable-to-access-secure-environment-variable-in-pull-request

ericgreenmix commented 3 years ago

@nover 2.17.1 is now out with these changes. Thanks!