2DegreesInvesting / tiltPlot

Plots for the TILT project
https://2degreesinvesting.github.io/tiltPlot/
GNU General Public License v3.0
0 stars 0 forks source link

Fix failing tests and checks #79

Closed maurolepore closed 8 months ago

maurolepore commented 8 months ago

Closes #89

This PR implements the minimum changes to pass checks on GitHub. It doesn't solve less critical issues.


TODO

EXCEPTIONS

maurolepore commented 8 months ago

I conclude:

Although this package remained the same, some checks that passed before fail now. This is most likely due to changes in dependencies: tiltIndicator and tiltToyData. I should try fix the issues then add a CI workflow in tiltIndicator and tiltToyData to avoid breaking tiltToyData.

maurolepore commented 8 months ago

For my own record. Here are some notable messages in the failed workflows. Nothing seems to point to toy data. I'll explore locally.

pkgdown

✖ Missing topics: map_region_risk
ℹ Either add to _pkgdown.yml or use @keywords internal

R CMD (ubuntu release)

The error most likely occurred in:
...
> ### Name: map_region_risk
> 
> ### ** Examples
...
> map_region_risk(financial, country_code = "DE", benchmark = "unit")
'make_valid' argument has been deprecated

Failed with error:  ‘there is no package called ‘giscoR’’
'giscoR' package is required for geospatial functionalities

Error in UseMethod("filter") : 
  no applicable method for 'filter' applied to an object of class "NULL"

...

tiltPlot/R/prepare_geo_data.R:45:3  
Error in `UseMethod("filter")`: no applicable method for 'filter' applied to an object of class "NULL"

── Warning ('test-plot_xctr_financial.R:2:3'): returns an object of the expected class ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
i Please use `"equal_weight_finance"` instead of `.data$equal_weight_finance`

── Warning ('test-plot_xctr_financial.R:2:3'): returns an object of the expected class ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
i Please use `"worst_case_finance"` instead of `.data$worst_case_finance`