Chrishat34s working reserve

[2e0byo]

Chrishat34s changes implementing working reserve. I'm going to leave this PR open for a bit so he can comment on it.

[2e0byo]

Other than that I understood everything. I've:

• refactored slightly, removing globals (that's what classes are for!)
• removed some comments, prints, etc from testing
• cleaned up in a few places
• removed hardcoded notify() code

Could you look over the new version and check you're happy with it? If so I'll merge.

Also, did you manage to book a test? How did it go? [If you didn't I guess you can test this version....]

[chrishat34]

apropos 200ab1d

@chrishat34 why was this necessary? I think it was just a typo s i cleaned things up a little - sorry to confuse

[chrishat34]

Hi, I would quite like to talk to you privately more about this if possible i.e. off here, email maybe?

[chrishat34]

and the sleeper added to humanlike as:

def sleeper():
    duration = randint(930, 1000)# was 930, 1000
    print(f"Sleeping for {duration} s")
    with Halo(spinner="dots"):
        sleep(duration)

[chrishat34]

Ok, i had a look through, 2 comments, ref scraper.py:

1. line 250, did you mean to remove the: with open("C:\git\new\YADC-master\yadc\errors\tmp\test.html", "w") as f: f.write(page)
2. line 281 ish, the last line with the user input stops the reserve bit running automatically!

[2e0byo]

@chrishat34 my email is (now) on my github profile. (I'll not put it here in case I remove it later).

Thanks for those comments; I'll factor them in later and then merge this. Thanks for getting it working!

[2e0byo]

Ok, i had a look through, 2 comments, ref scraper.py:

1. line 250, did you mean to remove the: with open("C:\git\new\YADC-master\yadc\errors\tmp\test.html", "w") as f: f.write(page)

Yes, it was left over from testing; that file is never used (it was just for me to look at).

2. line 281 ish, the last line with the user input stops the reserve bit running automatically!

You mean this line ? It won't run if self.reserve isn't set. However I need to document that and demonstrate it in main.py, thanks.

[chrishat34]

ok, all cool, thanks

On Tue, 18 Jan 2022 at 22:35, 2e0byo @.***> wrote:

Ok, i had a look through, 2 comments, ref scraper.py:

1. line 250, did you mean to remove the: with open("C:\git\new\YADC-master\yadc\errors\tmp\test.html", "w") as f: f.write(page)

Yes, it was left over from testing; that file is never used (it was just for me to look at).

1. line 281 ish, the last line with the user input stops the reserve bit running automatically!

You mean this line https://github.com/2e0byo/YADC/pull/5/files#diff-a9ebafc4fd06eacce2d24dae674c4b2dd42f5c1f1b4cf5c14eb694501121ad83R247 ? It won't run if self.reserve isn't set. However I need to document that and demonstrate it in main.py, thanks.

— Reply to this email directly, view it on GitHub https://github.com/2e0byo/YADC/pull/5#issuecomment-1015895364, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKMEXC3CWJMNY72USZW6MHTUWXTJVANCNFSM5MHCW5JQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

[2e0byo]

apropos 200ab1d

@chrishat34 why was this necessary?

I meant this commit, sorry, but it doesn't do any harm: 2f20200ffc5a1c7f2c12aafb99f64115a74c35ed