search

3dgeo-heidelberg / pytreedb

Python package providing a file and object-based database to store tree objects.
Other
28 stars 4 forks source link

Backend: Tests fail when providing "WindowsPath" to import_db() function #21

Closed lwiniwar closed 2 years ago

lwiniwar commented 2 years ago

In GitLab by @han16nah on Mar 16, 2022, 16:22

The import_db() function in dp.py seems to fail, when providing a WindowsPath (i.e., when using the pathlib module or the tmp_path fixture of pytest. It works when converting it to string, see test_db.py#L37.

I think it would be good to revise the function, so get it also accepts an object of type Path (see pathlib).

lwiniwar commented 2 years ago

In GitLab by @bhoefle-3dgeo on Mar 17, 2022, 10:05

@han16nah Should be fixed with latest commit. Please verify and close this issue. Fixed it also for import_data.

lwiniwar commented 2 years ago

In GitLab by @han16nah on Mar 17, 2022, 12:07

Can verify that it's fixed.