Make spec.envoyResources[*].name optional

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes

Apache License 2.0

58 stars 14 forks source link

Make spec.envoyResources[*].name optional #152

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

After the changes in #145 the name field is irrelevant and has no effect. This PR makes this field optional. The field will be removed in a future release.

/kind cleanup /kind documentation /priority important-soon /assign

slopezz commented 1 year ago

/lgtm

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: d728e237be132d4c306c4704a28a0b464fa868dc

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [raelga] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

roivaz commented 1 year ago

/ok-to-test