Revert "Drop usage of github.com/operator-framework/operator-lib/status"

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes

Apache License 2.0

58 stars 14 forks source link

Revert "Drop usage of github.com/operator-framework/operator-lib/status" #156

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

Reverts 3scale-ops/marin3r#155

This PR breaks the upgrade path due to the status.conditions[*].message property being now required. I need to add the message everywhere in the code before doing the library switch so OLM doesn't complain about existent resources not matching the spec.

/kind bug /priority important-soon /assign

raelga commented 1 year ago

/lgtm

slopezz commented 1 year ago

/lgtm

roivaz commented 1 year ago

/ok-to-test

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: 983adef083606819c8682dcdd67600cebac7e88b

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment