search

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes
Apache License 2.0
58 stars 14 forks source link

Don't restrict the types that can be unmarshalled #175

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

Make the unmarshal possible for any proto message, not just the top level ones. This is useful for when the serializer package is used form other project.

/kind feature /priority important-longterm /assign

roivaz commented 1 year ago

/ok-to-test

raelga commented 1 year ago

/lgtm

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: 1b745b33434116907d5dde3cb5e7ebdeb390114f

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment