Configurable priority class for the discovery service pod

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes

Apache License 2.0

56 stars 12 forks source link

Configurable priority class for the discovery service pod #181

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

Adds a field in the custom resource to configure the priority class for the DiscoveryService pod. Allowing the user to configure a high priority PriorityClass will make it less of a problem that this pod does not have HA as it can be configured to ensure it is always scheduled, even if it needs to preempt other pods with lower priority.

Also took the opportunity to clean up some things in the discoveryservice controller.

/kind feature /priority important-soon /assign

slopezz commented 1 year ago

/lgtm

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: 9b5f5fa7fd204f350b3186ecbf5c89c9e345b4a2

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment