search

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes
Apache License 2.0
56 stars 12 forks source link

Implement status for EnvoyDeployment and DiscoveryService #184

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

Makes use of https://github.com/3scale-ops/basereconciler/pull/1 to implement status for EnvoyDeployments and DiscoveryServices. It's a simple status that just surfaces the status of their respective managed Deployments to the custom resource status.

Implements feature request #165

/kind feature /priority important-longterm /assign /ok-to-test

slopezz commented 1 year ago

/lgtm

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: a803e7ce9ed93f966613ee22b588701dae89ec56

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment