search

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes
Apache License 2.0
58 stars 14 forks source link

Discovery service server improvements #185

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

Some improvements to the discovery service, most notable the implementation of healthz checks for this pod. I have added a gRPC healthz service to the same gRPC server where the xDS service runs. This checkis then aggregated by controller-runtime with the typical "ping" healthz checks we use for controllers.

This PR closes #46

/kind feature /priority important-soon /assign /ok-to-test

slopezz commented 1 year ago

/lgtm

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: 240fd0fda1cc7c8a3ecfccdef783a5711c33b053

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment