search

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes
Apache License 2.0
58 stars 14 forks source link

Add deprecation notice on field #186

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

Add deprecation notice on the spec.envoyResources.secrets[*].ref field. The code ignores this field and should be removed in an upcoming release. Actually use of the whole spec.envoyResources is now deprecated, but being explicit with this anyway.

Also adding some changes to the generated file apis/operator.marin3r/v1alpha1/zz_generated.deepcopy.go which I missed from a previous PR.

/kind documentation /priority important-soon /assign /ok-to-test

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: 82b2accf9aebdb5e8ffee061cd5b97e14fd250c4

slopezz commented 1 year ago

/lgtm

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment