search

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes
Apache License 2.0
56 stars 12 forks source link

Harden requirements for taint #187

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

This PR raises the number of NACKs required to consider an envoy Pod as failing to 5. So far, a single failure was enough to mark a pod as failing to load a given configuration revision. This was problematic when running a single pod setup, where a single failure would cause a revision to get tainted. The change also has the side effect of making the taint process much slower, due to the fact that we now must wait for 5 failures and there's an exponential backoff mechanism in place when failures occur. To improve this a bit I have reduced the periodic reconcile of EnvoyConfigRevisions to 30 seconds.

/kind bug /priority important-soon /assign /ok-to-test

slopezz commented 1 year ago

/lgtm

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: e24c51acd5420e89789341e7ff226c7c038c9ce0

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment