search

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes
Apache License 2.0
56 stars 12 forks source link

Fix rollout of the discovery service #190

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

With the addition of health checks, the rollout of new versions of the discovery service is slower because the new pod takees some seconds to pass the health checks. This makes that both the old controllers and the new ones run in parallel for some seconds, trying to write to the same EnvoyConfigRevisions and causing problems. To fix this:

I have tested an upgrade from v0.11.1 to a version with the changes in this PR and it fixes the problems.

/kind bug /priority critical-urgent /assign /ok-to-test

slopezz commented 1 year ago

/lgtm

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: b56536786f6f5a7393b3ac1d70f243a272a0f680

raelga commented 1 year ago

/lgtm

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment