Subscribe the controller to the appropriate events

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes

Apache License 2.0

56 stars 12 forks source link

Subscribe the controller to the appropriate events #192

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

Fixes a very minor bug in the EnvoyDeployment controller, which was missing some watches over the child resources.

/kind bug /priority important-soon /assign /ok-to-test

slopezz commented 1 year ago

/lgtm

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: f507a13982d1bbeacac09779e05b33833f1325c4

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment