search

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes
Apache License 2.0
56 stars 12 forks source link

fix/gorutine-leak #201

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

The discovery service grpc health check was leaving open connections and causing a goroutine leak.

Also raise the context timeout for the discovery service healthz checks as it was too aggressive.

/kind bug /priority important-soon /assign

slopezz commented 1 year ago

/lgtm

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: 28fb4578bce53eeda5b76f82ceb7df7ffbd85aab

raelga commented 1 year ago

/lgtm

roivaz commented 1 year ago

/ok-to-test

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment