search

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes
Apache License 2.0
58 stars 14 forks source link

Unit test failure - expired cert? #204

Closed ghost closed 1 year ago

ghost commented 1 year ago 
$ go test -p 6 ./pkg/util/pki/...
--- FAIL: TestGenerateCertificate (0.42s)
    --- FAIL: TestGenerateCertificate/Generates_a_ca-signed_server_certificate (0.17s)
        generate_test.go:120: GenerateCertificate() error validating certificate = x509: certificate has expired or is not yet valid: current time 2023-08-04T10:28:20-04:00 is after 2023-07-12T11:05:27Z

            -----BEGIN CERTIFICATE-----
            MIICwzCCAiSgAwIBAgIQGLmXRXuNN1VL8sQ9dMMG5DAKBggqhkjOPQQDBDA7MRsw
            GQYDVQQKExJtYXJpbjNyLjNzY2FsZS5uZXQxHDAaBgNVBAMTE21hcmluM3ItY2Et
            aW5zdGFuY2UwHhcNMjMwODA0MTQyODIwWhcNMjMwODA0MTQzMzIwWjAsMRswGQYD
            VQQKExJtYXJpbjNyLjNzY2FsZS5uZXQxDTALBgNVBAMTBHRlc3QwggEiMA0GCSqG
            SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMkCxYmzvedQ61lJzv48C42R51yXsRux+W
            fIwh/vUwAON4mjGzE86NP0t3Ww2TO7KbxYAFjFqkQYUsm2LmEuKqxgrOJgmwsW2f
            eLJWZEw7vwcm3M5tQUlcrOH7UA266SraHuZX8x47Jd1mvjDTI5jXhVA1uKVBFdVX
            PS7TufgNJMjOb3Alo4GvLMlCcoACAjvs3neOoB2XI1EdCdLSk9vgDebZIefHvnJ+
            DBF/8pomqACUu3y/C34aSVPwyVmAzUkNeH9Fdqh5I07xMOC/8oWFMgQq2FqSGA6M
            aWmyoham2GtDn0W4qkamxPvncf2SWeoTxUOvs9/DyMUFjbnTbseLAgMBAAGjTjBM
            MA4GA1UdDwEB/wQEAwIFoDATBgNVHSUEDDAKBggrBgEFBQcDATAMBgNVHRMBAf8E
            AjAAMBcGA1UdEQQQMA6CDGV4YW1wbGUudGVzdDAKBggqhkjOPQQDBAOBjAAwgYgC
            QgGA9lXpNBQ68TD4XTGjsdbfGnLbekuJ9ZjNJoS5BrTvd7SgDLdHVjac76+jYisR
            Oba9ITt4ObQFwUOikPPn8ePXcQJCAZplnnIAdZUZkKHucDN002Lt60ZfQ09TxCIM
            T7ZcMQdsr4yo8jO4yS0T/b/zvLtfRQplMty3datRfcQDB7Y13arX
            -----END CERTIFICATE-----
--- FAIL: TestVerify (0.00s)
    --- FAIL: TestVerify/Certificate_is_valid (0.00s)
        verify_test.go:90: Verify() error = x509: certificate has expired or is not yet valid: current time 2023-08-04T10:28:20-04:00 is after 2023-07-12T11:05:27Z, wantErr false
FAIL
FAIL    github.com/3scale-ops/marin3r/pkg/util/pki      0.546s
FAIL

Possible clue: the cert embedded in generate_test.go expired recently: NotAfter:time.Date(2023, time.July, 12, 11, 5, 27, 0, time.UTC)

ghost commented 1 year ago

/kind bug

ghost commented 1 year ago

I'm updating the certs and will submit a PR when I've got it working.