3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes
Apache License 2.0
58 stars 14 forks source link

Update test certs #205

Closed ghost closed 1 year ago

ghost commented 1 year ago

This updates the unit test cert (which had expired), changes the unit tests so they share certs instead of each having their own, and has a janitorial commit to update the generated yaml files to match the makefile-specified controller-tools version.

/closes #204

ghost commented 1 year ago

/kind bug

ghost commented 1 year ago

Sorry for closing and reopening, I guess I had a git brainfart.

ghost commented 1 year ago

/priority high

Seems like high priority is justified since the build is broken.

3scale-robot commented 1 year ago

@acnodal-tc: The label(s) priority/high cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/3scale-ops/marin3r/pull/205#issuecomment-1668649297): >/priority high > >Seems like high priority is justified since the build is broken. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ghost commented 1 year ago

/priority important-soon

roivaz commented 1 year ago

/ok-to-test

roivaz commented 1 year ago

/lgtm /approve

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: 1c3fa893eee20ee8cf3ac96a05855947d0317ab2

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment