search

3scale-ops / marin3r

Lightweight, CRD based envoy control plane for kubernetes
Apache License 2.0
56 stars 12 forks source link

Upgrate to basereconciler v0.3.0 #206

Closed roivaz closed 9 months ago

roivaz commented 10 months ago

Fixes a bug in resource deletion.

3scale-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from roivaz by writing /assign @roivaz in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/3scale-ops/marin3r/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
3scale-robot commented 10 months ago

@roivaz: There are no kind on this issue. Please add an appropriate kind by using one of the following commands:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
roivaz commented 10 months ago

/ok-to-test

slopezz commented 10 months ago

/lgtm

3scale-robot commented 10 months ago

LGTM label has been added.

Git tree hash: d756255ddfa640a492dd263d982c84dd7435a19a

raelga commented 10 months ago

/lgtm

roivaz commented 9 months ago

Won't merge this and will bump directly to v0.3.2

/close

3scale-robot commented 9 months ago

@roivaz: Closed this PR.

In response to [this](https://github.com/3scale-ops/marin3r/pull/206#issuecomment-1761154721): >Won't merge this and will bump directly to v0.3.2 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.