404-wave / 404-project

CMPUT 404 Distributed Social Network
https://cmput404-wave.herokuapp.com/
Apache License 2.0
2 stars 3 forks source link

Allow for login for unapproved users #6

Open sewingpillows opened 5 years ago

sewingpillows commented 5 years ago

Is your feature request related to a problem? Please describe. Currently there are a couple todos in register.html and login.html that sound like we won't allow user to login if they are unapproved. This is a probably pretty frustrating for the user, and would require us to program in some messages on login/register page.

Describe the solution you'd like Instead - we can allow unapproved users to login, just direct them to a stripped down homepage explaining they are in 'limbo'. So we would have three types of homepage access (admin/user/waiting-for-approval-user). They will not have access to any area expect for their profile. Other users will not know they exist. We could even be cheeky and call this area limbo. The benefit of this is no weird validation on login/registration, and a much cleaner experience for the user that still gives them something.

Describe alternatives you've considered This is an alternative.

Z-Red commented 5 years ago

The spec states, "As a server admin, I want to be able allow users to sign up but require my OK to finally be on my server."

I took that as meaning they couldn't access the site at all until approved. However, I do agree that there should be some message informing them that they cannot use features of the site until approved. Perhaps they can still change their information, but they should not be allowed to post, view feeds, or search for other individuals.

Actually, implementing this is really not very hard. We can simply encapsulate all "approved" level features in if-blocks (checking for approved status) so the HTML will not even render.

I'd say that once we get a decent profile page going we could definitely implement this quality of life change.