search

4950 / DirtyGame

CSCI 4950 Project
csci4950.azurewebsites.net
3 stars 0 forks source link

Fix landmine animation #218

Open JaredPoetter opened 10 years ago

Duffman9205 commented 10 years ago

Started working on in LandmineAnimation branch. Landmines are currently projectiles with 0 speed, so instead of doing damage through the DealDamage method, I changed it so they create an AOE field (similar to suicide bomber and grenades).

However, I noticed that DealDamage (in WeaponSystem.cs) had some landmine specific code, some of which was marked "Ling's bad code". @lingqingmeng , what do you think about the changes I've made? What further changes would need to be made to fix your "bad code" in light of this?

bkern24 commented 10 years ago

With this I noticed there is a console.writeline in the Projectile system i believe. Its for the landmines. @lingqingmeng Any reason for this in develop? Im assuming its you as you did the landmines, if not then maybe its @dawl code

lingqingmeng commented 10 years ago

Ling's bad code represents our working version of the landmines, albeit not perfectly. I"ll take a look at it tonight.

On Sun, Mar 2, 2014 at 6:53 PM, bkern24 notifications@github.com wrote:

With this I noticed there is a console.writeline in the Projectile system i believe. Its for the landmines. @lingqingmeng https://github.com/lingqingmeng Any reason for this in develop? Im assuming its you as you did the landmines, if not then maybe its @dawl https://github.com/dawl code

Reply to this email directly or view it on GitHubhttps://github.com/4950/DirtyGame/issues/218#issuecomment-36474102 .

lingqingmeng commented 10 years ago

At work, so I'm unaware of the changes made (regarding this), but essentially as long as the landmine extracts its damage value from Monsters.xml it should be enough to have it be of quality in develop.

On Tue, Mar 4, 2014 at 3:04 PM, Ling Qing Meng ling.q.meng@gmail.comwrote:

Ling's bad code represents our working version of the landmines, albeit not perfectly. I"ll take a look at it tonight.

On Sun, Mar 2, 2014 at 6:53 PM, bkern24 notifications@github.com wrote:

With this I noticed there is a console.writeline in the Projectile system i believe. Its for the landmines. @lingqingmeng https://github.com/lingqingmeng Any reason for this in develop? Im assuming its you as you did the landmines, if not then maybe its @dawl https://github.com/dawl code

Reply to this email directly or view it on GitHubhttps://github.com/4950/DirtyGame/issues/218#issuecomment-36474102 .