search

4teamwork / opengever.core

OneGov GEVER core package
11 stars 5 forks source link

Personal overview: Cannot filter by task type / forward #334

Closed phabegger closed 10 years ago

phabegger commented 10 years ago

bildschirmfoto 2014-06-24 um 22 10 53

This won't work: bildschirmfoto 2014-06-24 um 22 11 31

Seems like "Auftragstyp" + "Weiterleitung" are not in SearchableText...

phgross commented 10 years ago

Yes thats right the task_type is not included in the SearchableText at the moment. But the searchableText could be easy extended.

The only problem I've see is that we save an identifier for the type and not the translated string, but we would need the translated string to filter reasonable on task_type.

We could extend the searchable Text with all languages (german, french at the moment). @lukasgraf what do you think?

lukasgraf commented 10 years ago

@phgross sounds like a pragmatic approach, :+1:. It would be nice if we could determine all supported languages ('de', fr') programmatically instead of hard-coding them, but other than that it's the right thing to do I think.

Edit: portal_languages.getSupportedLanguages() seems to do the trick. Returns ['fr', 'de'] for a PHVS installation and ['de-ch'] for a regular installation. So the difference between de and de-ch would have to be dealt with (or PHVS setup would have to be fixed to use de-ch, which would be the correct language code).

deiferni commented 10 years ago

I Just implemented this for task_type in #357, but at the moment not all table columns displayed for Task are searchable (same goes for Dossier and probably for other types). I have opened an new issue #358.

deiferni commented 10 years ago

Update, we changed tasks-source for almost all tabs to globalindex, i.e. SQL. Updating SearchableText does not help here. Instead we should modify tabbedview.browser.extend_query_with_textfilter. But at the moment we do not store task-state labels. This raises the following questions:

phgross commented 10 years ago

The filter problem will be adressed as soon as a global-task-service is implemented. Correct solution is to use Fulltext-Index but we won't do this in oralce :disappointed: