List of office connector editable types differs in dev, test and prod.

deiferni commented 5 years ago

Curiosity 1: the field officeconnector_editable_types is only defined in zcml, but not on the IOfficeConnectorSettings interface.
Curiosity 2: the values vary between production our test and local development. we don't seem able to update the list very reliably.

local dev, missing visio for fresh deployments:

application/illustrator
application/msword
application/onenote
application/pdf
application/postscript
application/rtf
application/vnd.mindjet.mindmanager
application/vnd.ms-excel
application/vnd.ms-excel.addin.macroEnabled.12
application/vnd.ms-excel.sheet.binary.macroEnabled.12
application/vnd.ms-excel.sheet.macroEnabled.12
application/vnd.ms-excel.template.macroEnabled.12
application/vnd.ms-powerpoint
application/vnd.ms-powerpoint.addin.macroEnabled.12
application/vnd.ms-powerpoint.presentation.macroEnabled.12
application/vnd.ms-powerpoint.slideshow.macroEnabled.12
application/vnd.ms-project
application/vnd.ms-word.document.macroEnabled.12
application/vnd.ms-word.template.macroEnabled.12
application/vnd.openxmlformats-officedocument.presentationml.presentation
application/vnd.openxmlformats-officedocument.presentationml.slideshow
application/vnd.openxmlformats-officedocument.presentationml.template
application/vnd.openxmlformats-officedocument.spreadsheetml.sheet
application/vnd.openxmlformats-officedocument.spreadsheetml.template
application/vnd.openxmlformats-officedocument.wordprocessingml.document
application/vnd.openxmlformats-officedocument.wordprocessingml.template
application/vnd.visio
application/x-indesign
application/x-iwork-keynote-sffkey
application/x-iwork-numbers-sffnumbers
application/x-iwork-pages-sffpages
application/x-mspublisher
application/x-project
image/bmp
image/gif
image/jpeg
image/jpg
image/png
image/tiff
image/vnd.adobe.photoshop
text/css
text/csv
text/html
text/plain
text/richtext
text/tab-separated-values
text/xml

our test

application/illustrator
application/msword
application/onenote
application/pdf
application/postscript
application/rtf
application/vnd.mindjet.mindmanager
application/vnd.ms-excel
application/vnd.ms-excel.addin.macroEnabled.12
application/vnd.ms-excel.sheet.binary.macroEnabled.12
application/vnd.ms-excel.sheet.macroEnabled.12
application/vnd.ms-excel.template.macroEnabled.12
application/vnd.ms-powerpoint
application/vnd.ms-powerpoint.addin.macroEnabled.12
application/vnd.ms-powerpoint.presentation.macroEnabled.12
application/vnd.ms-powerpoint.slideshow.macroEnabled.12
application/vnd.ms-project
application/vnd.ms-visio.drawing
application/vnd.ms-visio.drawing.macroEnabled.12
application/vnd.ms-word.document.macroEnabled.12
application/vnd.ms-word.template.macroEnabled.12
application/vnd.openxmlformats-officedocument.presentationml.presentation
application/vnd.openxmlformats-officedocument.presentationml.slideshow
application/vnd.openxmlformats-officedocument.presentationml.template
application/vnd.openxmlformats-officedocument.spreadsheetml.sheet
application/vnd.openxmlformats-officedocument.spreadsheetml.template
application/vnd.openxmlformats-officedocument.wordprocessingml.document
application/vnd.openxmlformats-officedocument.wordprocessingml.template
application/vnd.visio
application/x-indesign
application/x-iwork-keynote-sffkey
application/x-iwork-numbers-sffnumbers
application/x-iwork-pages-sffpages
application/x-mspublisher
application/x-project
image/bmp
image/gif
image/jpeg
image/jpg
image/png
image/tiff
image/vnd.adobe.photoshop
text/css
text/csv
text/html
text/plain
text/richtext
text/tab-separated-values
text/xml

in prod for one customer:

application/illustrator
application/msword
application/onenote
application/pdf
application/postscript
application/rtf
application/vnd.mindjet.mindmanager
application/vnd.ms-excel
application/vnd.ms-excel.addin.macroEnabled.12
application/vnd.ms-excel.addin.macroenabled.12
application/vnd.ms-excel.sheet.binary.macroEnabled.12
application/vnd.ms-excel.sheet.binary.macroenabled.12
application/vnd.ms-excel.sheet.macroEnabled.12
application/vnd.ms-excel.sheet.macroenabled.12
application/vnd.ms-excel.template.macroEnabled.12
application/vnd.ms-excel.template.macroenabled.12
application/vnd.ms-powerpoint
application/vnd.ms-powerpoint.addin.macroEnabled.12
application/vnd.ms-powerpoint.addin.macroenabled.12
application/vnd.ms-powerpoint.presentation.macroEnabled.12
application/vnd.ms-powerpoint.presentation.macroenabled.12
application/vnd.ms-powerpoint.slideshow.macroEnabled.12
application/vnd.ms-powerpoint.slideshow.macroenabled.12
application/vnd.ms-project
application/vnd.ms-visio.drawing
application/vnd.ms-visio.drawing.macroEnabled.12
application/vnd.ms-word.document.macroEnabled.12
application/vnd.ms-word.document.macroenabled.12
application/vnd.ms-word.template.macroEnabled.12
application/vnd.ms-word.template.macroenabled.12
application/vnd.openxmlformats-officedocument.presentationml.presentation
application/vnd.openxmlformats-officedocument.presentationml.slideshow
application/vnd.openxmlformats-officedocument.presentationml.template
application/vnd.openxmlformats-officedocument.spreadsheetml.sheet
application/vnd.openxmlformats-officedocument.spreadsheetml.template
application/vnd.openxmlformats-officedocument.wordprocessingml.document
application/vnd.openxmlformats-officedocument.wordprocessingml.template
application/vnd.visio
application/x-indesign
application/x-iwork-keynote-sffkey
application/x-iwork-numbers-sffnumbers
application/x-iwork-pages-sffpages
application/x-mspublisher
application/x-project
image/bmp
image/gif
image/jpeg
image/jpg
image/png
image/tiff
image/vnd.adobe.photoshop
text/css
text/csv
text/html
text/plain
text/richtext
text/tab-separated-values
text/xml

deiferni commented 5 years ago

Possible solution: only set registry value when the customer wants to customize the list. Otherwise fall back to programmatic default. That would eliminate the need to figure out if the list can be updated in an og.core upgrade step (which imo is not so easily possible).

Rotonen commented 5 years ago

I'm planning on introducing a gever-side-only whitelist and a per policy blacklist to address this.

deiferni commented 5 years ago

That would automatically add new entries on the GEVER side to the policies. Not sure if that is desired as new entries will most likely more and more specific and it would force us to keep the policies in sync all the time.

Rotonen commented 5 years ago

We currently need to double check in any case.

deiferni commented 5 years ago

quick summary of discussion and proposed implementation:

provide default list, with possibility to override on a per-customer basis
have default in python, as a list or something
if registry contains list of mimetypes use those
if registry field is empty, fall back to default
check customer policies once and make sure the setting is correct after this upgrade (we need to do this anyway as at least one is in a 💩 state)
after that we can change the default without having to worry about messing with overrides. i'm expecting the overrides to be stable in any case as they usually depend on the customers environment (installed desktop apps, ...)

lukasgraf commented 5 years ago

Discussed this again, and I suggested an approach where we don't let policies override the entire set, but instead go with a default set (defined in Python code) that is added and subtracted from by whitelists and blacklists respectively, which are defined as registry settings.

Informally approved by @deiferni 😉

4teamwork / opengever.core

List of office connector editable types differs in dev, test and prod. #5318