search

4teamwork / opengever.core

OneGov GEVER core package
11 stars 5 forks source link

switch solr highlighter? #5440

Open njohner opened 5 years ago

njohner commented 5 years ago

Harvest: OneGov GEVER - Softwarepflege (Refactoring/Bug)

In some circumstances, solr returns snippets that are very large and do not respect the default fragment size (hl.fragsize=100). After some testing and reading (https://lucene.apache.org/solr/guide/6_6/highlighting.html#Highlighting-ChoosingaHighlighter), we could think of changing for the unified highlighter. In the documentation they say it stands out as the most flexible and performant of the options. and from my tests it respects the fragment size.

Maybe we should switch (add 'hl.method': 'unified' in opengever/base/browser/search.py)?

see https://extranet.4teamwork.ch/support/edk/tracker-support-gever-edk/135

deiferni commented 5 years ago

just fyi and maybe something to keep in mind here: we had issues in the past with escaping of the already highlighted results (they are inserted as html structure), see https://github.com/4teamwork/opengever.core/commit/2a34e3ac5aa0.

phgross commented 5 years ago

@buchi wie schätzt du das ein?