search

4teamwork / opengever.core

OneGov GEVER core package
11 stars 5 forks source link

Sign workflow #8034

Closed elioschmutz closed 3 weeks ago

elioschmutz commented 1 month ago

This PR extends the document workflow with all the necessary states and transitions to be able to implement the sign process.

It does not yet implement the transition extenders and the transitions will only be available if the sign-feature is available.

The transition extenders will be implemented in an upcoming PR. This PR is meant for a pre-review for the naming, permissions and available states and transitions.

Bildschirmfoto 2024-08-30 um 09 51 08

ℹ️ the document-workflow is simplified in this diagram. Trash and shadow states and transitions are not visible.

For TI-659

elioschmutz commented 1 month ago

LGTM 👍, but

No transition guards yet for moving the document into the signing state? No tests yet? I think tests like these could be useful already:

In the signing state, it should be impossible to

  • Delete the document
  • Copy or move the document
  • Checkout the document
  • Revert the document to a previous version
  • Probably some other things I can't think of right now ;)

As discussed. I pushed the PR very quickly to get an early feedback about the naming of the states, transitions, permissions and the workflow in general. I pushed all the missing parts in the meantime.

So it should be ready for a final review now.

elioschmutz commented 4 weeks ago

@lukasgraf could you take a final look?