5-stones / react-native-readium

📚 📖 React Native ebook reader for iOS, Android, & Web via Readium
MIT License
83 stars 25 forks source link

Full screen causes problems on Android #22

Closed M-HARIS-97 closed 1 year ago

M-HARIS-97 commented 1 year ago

Readium full screen option works well on iOS. But it doesn't work well on Android.

In android :- Title and status bar part is not hidden in full screen option. Is there an option to enable / disable full screen? Also, how to handle the bottom page number indication? (Page number hint doesn't work on Android)

Please check the following screenshots;

iOS Simulator Screen Shot - iPhone 13 - 2022-12-15 at 11 30 29

android image

jspizziri commented 1 year ago

@M-HARIS-97 please file a separate issue for page numbers.

As for this issue, the ReadiumView should be filling 100% of its parent so please check the parent. Please recreate this in the example app. I can't really help you with much until you do that.

M-HARIS-97 commented 1 year ago

@jspizziri Under normal circumstances, it works fine. But if we use a navigation header on the reading page, it doesn't fill 100% of its parent.

jspizziri commented 1 year ago

@M-HARIS-97 that sounds like an artifact of how your navigation component works, not this library. If you can demonstrate otherwise via the example repo I'll re-open this issue.

M-HARIS-97 commented 1 year ago

@jspizziri But it works fine on iOS. I use the same navigation header on iOS as well

iOS with header

Simulator Screen Shot - iPhone 13 - 2022-12-15 at 19 58 13

iOS without Header

Simulator Screen Shot - iPhone 13 - 2022-12-15 at 19 58 21

Anyway, I'll check out the example repo and update you

jspizziri commented 1 year ago

@M-HARIS-97 the navigation library itself could behave differently between those two platforms. That doesn't indicate an issue with this lib.

M-HARIS-97 commented 1 year ago

@jspizziri Ok

M-HARIS-97 commented 1 year ago

@jspizziri How to disable the full screen feature?

jspizziri commented 1 year ago

@M-HARIS-97 I'm not sure what you're asking. The view should simply be filling 100% of it's parent, so if you wrap it in a parent View of a certain size it should respect that.

M-HARIS-97 commented 1 year ago

@jspizziri Got it ok. Ty :)

M-HARIS-97 commented 1 year ago

@jspizziri Is there a way to prevent the fill 100%? Because i am using parent height value is "device height - 100" but when i click Readium view it fills device height automatically. I was able to reproduce this problem using the sample project. Steps;

  1. Add height property (device height - 100)
  2. Click on Readium view body part
  3. Then the Readium view height changes oddly
jspizziri commented 1 year ago

@M-HARIS-97 fork this project and create a repro in the example.

andrebeolchi commented 1 year ago

I'm having problems with fullscreen on android, to be honest I would like to remove it, is there any way to do this?

The app's fullscreen on android does not remove the React Navigation Header, and besides, if I activate and deactivate the fullscreen a few times in a row, the location starts to "return" to the beginning of the chapter. I believe that removing the fullscreen action solves the location problem

the fullscreen action I mean, is when you click in the middle of the screen

Example