search

5-stones / react-native-readium

📚 📖 React Native ebook reader for iOS, Android, & Web via Readium
MIT License
83 stars 25 forks source link

[Bug] Scroll setting is not working properly on Android #23

Closed M-HARIS-97 closed 1 month ago

M-HARIS-97 commented 1 year ago

Please check the following video;

https://user-images.githubusercontent.com/57429370/207814193-abd50882-ebb3-4183-883a-e340d9d67b6b.mp4

jspizziri commented 1 year ago

@M-HARIS-97 please create a reproduction in the example app. I haven't seen this before.

M-HARIS-97 commented 1 year ago

@jspizziri This epub has overflow-x: hidden / overflow-x: visible CSS for the<body> tag. That is what is causing this.

jspizziri commented 1 year ago

@M-HARIS-97 glad you sorted it out.

mickael-menu commented 1 year ago

This particular issue should be fixed in the next version of the Kotlin toolkit, see https://github.com/readium/kotlin-toolkit/pull/294

jspizziri commented 1 year ago

@mickael-menu , wow! Thanks for letting us know! 🙏

How did this come across your radar in this project?

mickael-menu commented 1 year ago

I found this wrapper thanks to you actually 😄 I'm subscribed to the activity now.

Feel free to come participate in our bi-weekly Zoom calls or API discussions on Slack and the Readium repos. The more the merrier!

jspizziri commented 1 year ago

@mickael-menu I just might do that! Where can I find the invite links?

mickael-menu commented 1 year ago

You should receive a Slack invitation by mail soon, let me know if you don't. Our Zoom calls are notified on the #general channel but we're taking a break until end of January to figure out what's the best timing and cast.

jspizziri commented 1 year ago

@M-HARIS-97 kotlin-tooklit 2.3.0 has been released. As mentioned above the fix for this issue is contained in that release.

What remains to be done is to upgrade this library to use that version. Based on the migration guide it looks like there are several changes we'll need to make (specifically to how preferences work) in order to upgrade.

I encourage you to investigate and put together a PR if you need this fix soon. As for our team, it will probably be a while before it falls on our roadmap.

mickael-menu commented 1 year ago

The changes regarding the Preferences API and the HTTP server are optional in 2.3.0. However the Decoration.extras and PDF support sections in the migration guide are required to upgrade.

jspizziri commented 1 month ago

@M-HARIS-97 i've just merged an upgrade to kotlin-toolkit@2.4.1, which should resolve this issue.