search

5-stones / react-native-readium

📚 📖 React Native ebook reader for iOS, Android, & Web via Readium
MIT License
83 stars 25 forks source link

Full screen causes problems on Android #32

Closed andrebeolchi closed 5 months ago

andrebeolchi commented 1 year ago

I'm having problems with fullscreen on android, to be honest I would like to remove it, is there any way to do this?

The app's fullscreen on android does not remove the React Navigation Header, and besides, if I activate and deactivate the fullscreen a few times in a row, the location starts to "return" to the beginning of the chapter. I believe that removing the fullscreen action solves the location problem

the fullscreen action I mean, is when you click in the middle of the screen

test.webm

jspizziri commented 1 year ago

@andrebeolchi I'm not entirely sure that the app should be responsible for removing your navigation header. I think disabling the native tap event would be best. What would potentially be even better would be to emit an event to the JS side if a tap did occur.

Open to a PR for this.

jspizziri commented 5 months ago

Closing due to inactivity.

amalStorilabs commented 3 months ago

Have you solved this issue @andrebeolchi @jspizziri ?