search

5-stones / react-native-readium

📚 📖 React Native ebook reader for iOS, Android, & Web via Readium
MIT License
83 stars 25 forks source link

chore(android): upgrade readium android #38

Closed adesege closed 1 month ago

jspizziri commented 1 year ago

@adesege friendly ping on this one. What's the status of this PR? What work remains to be completed on it.

jspizziri commented 1 year ago

I tested this and found that it currently doesn't build.

casperolesen commented 1 year ago

@jspizziri

Do you also get the 'Unable to load script. Make sure you're either running Metro or that you bundle 'index.android.bundle' is packaged correctly for release?

jspizziri commented 1 year ago

@casperolesen I can't remember if I did or not. In any case, there's work needed on this to make it run.

casperolesen commented 1 year ago

I'm currently also trying to bump android, because it can't run in our current RN 0.72 setup.

yarn android --mode release seems to work

yarn android gives the error Unable to load script. Make sure you're either running Metro or that you bundle 'index.android.bundle' is packaged correctly for release

jspizziri commented 12 months ago

@casperolesen I'm not sure if the issue you're talking about is specific to this branch or not? If it is, I'm not sure I'm able to help right now. If it's not, please create a reproduction off of main based on the example project and create a new issue.

jspizziri commented 1 month ago

@adesege if you're still using this library let me know, and we can open this discussion back up. I just finished an upgrade to the latest react-native version and kotlin-toolkit 2.4.1