5-stones / react-native-readium

📚 📖 React Native ebook reader for iOS, Android, & Web via Readium
MIT License
78 stars 23 forks source link

[Bug] ERROR Warning: Function components cannot be given refs. #52

Closed robert-elles closed 3 weeks ago

robert-elles commented 3 months ago

The error warning occurs when following the guide to build and run the example app [Example App] (https://github.com/5-stones/react-native-readium/blob/main/example/README.md). It is shown in Metro after the app starts (see screenshot). There is also a warning pop up in the app itself (see second screenshot).

Screenshot 1 - Metro Screenshot 2 - App

jspizziri commented 1 month ago

@robert-elles thanks for this bug report and subsequent PR. I just wanted to let you know that it's on my radar. I've been working on a fairly large upgrade to the most recent version of React Native. Once that's done and merged, I intend to investigate this and review your PR.

jspizziri commented 3 weeks ago

@robert-elles I've just merged an upgrade to the latest stable version of react-native. If you're still able, it'd be great to get your branched rebased on main. Then I'll pull it down and test it. If you're not able to rebase, I'll just have to fork your branch and do the rebase myself. LMK.

jspizziri commented 3 weeks ago

Fixed by https://github.com/5-stones/react-native-readium/pull/61