search

52North / sensorweb-server-sta

Other
11 stars 12 forks source link

$filter by <RelatedEntity>/id not working #44

Open SpeckiJ opened 4 years ago

SpeckiJ commented 4 years ago

The refactor of identifiers to String broke the filtering by related Entity Id. Specification cannot be used by javax.persistence as it is a novel spring concept.

Example for a broken Implementation: https://github.com/52North/sensor-things/blob/00fca0851a51e8d622e107edb6b7739626750f21/sensor-things-api-core/src/main/java/org/n52/sta/data/query/ObservationQuerySpecifications.java#L120

ohmtyagi commented 1 year ago

Hi there! I'm interested in contributing to this project and I've identified Issue #[44] as something I'd like to work on. It seems to be a bug, and I'd like to take a shot at fixing it. I'd greatly appreciate any guidance or suggestions from the maintainers and experienced contributors. If you have any insights about the bug or the best way to approach it, I'm all ears! Looking forward to contributing to this project and collaborating with the community. Let's make the software even better together! Best regards, Ohm Tyagi

ohmtyagi commented 1 year ago

I've reviewed the issue and here's my initial understanding of the problem:

In this issue, there's a situation where a software project made a change to treat identifiers as Strings instead of their previous data type. However, this change caused an unexpected issue when trying to filter or query entities based on their related Entity Ids. The problem seems to stem from the way the Java Persistence API (javax.persistence) interacts with this new setup.

This issue is particularly interesting because it highlights a clash between a traditional javax.persistence approach and a novel concept introduced by the Spring Framework, which is likely influencing how identifiers are now handled as Strings. Essentially, this novel Spring concept is at odds with the established way of filtering data using the Java Persistence API.

The provided example in the GitHub issue showcases the problem in a specific file and line number in the project's source code. To address this, a solution would involve delving into the intricacies of how identifiers are being treated, understanding the interplay between the Spring Framework's concept and the Java Persistence API, and devising a strategy to enable effective filtering by related Entity Ids once again.

Swastik-123 commented 1 year ago

I think the problem is already solved if it is so then closed it