-
Example:
```
// foo
// bar
syntax = "proto3";
// baz
package bat;
```
`// bar` is the `Comment` on the `Syntax` object, and `// baz` is the `Comment` on the `Package` object. `// f…
-
On a fresh clone of the repo:
```
~/go/src/github.com/uber/prototool (dev) 13:51:16
$ make
git status --short > /var/folders/nk/lrxg8bsn08l9c4w9ld_00v440000gn/T/checknodiffgenerated_pre.XXXXX.I…
-
As discussed in #809
Let's add`OriginToken() string` to https://godoc.org/go.uber.org/yarpc#Call
`OriginToken()` would return a string representation identifying where the message came from.
…
-
Lets say we have a type `A:foo` in the graph.
Currently, requesting for type `A` will result in an error, since unique identification for an object is type+key.
We can make this experience a lot…
-
Currently, handlers often use `yarpc.CallFromContext` to access metadata about the current request. However, these handlers are difficult to unit test, because constructing a context that contains a c…
-
We should use the opentracing API to submit attributes/tags on a span context with the YARPC versions and other metadata.
-
Server and client interfaces use upper cased parameter names for service methods.
https://github.com/yarpc/yarpc-go/blob/fdbad937b763e420178cde657f4de8b1dffaf115/internal/examples/thrift-keyvalue/k…
-
Thrift envelopes are in an inconsistent state across our tools:
- `yab` defaults to envelope on for HTTP (b/c with Apache Thrift HTTP servers), but disables enveloping for TChannel.
- `yarpc-go` 1…
-
I've been talking to @abhinav about this, In order to support use cases where a dig parameter depends on multiple inputs of the same type we need the ability to aggregate dig types together.
So if …
-
## LifecycleOnce semantics require a lock to implement SetRouter without setting off a data race with go test -race
Right now, we use the `LifecycleOnce` interface to do locking in `transport.Inbou…