-
NOTE: Always conduct a peer-review with your peers in Slack, this will improve performance and ability to problem solve! 💯
-
**Grade: Meets expectations**
**Summary:** I thought this was an overall great attempt of the Colmar project. All of your content did adjust for mobile and desktop view. There were some minor issue…
-
The common convention is to separate words in css selectors with -
.section-one { }
.section-two { }
Lot easier to read.
Secondly you want to avoid names with version numbers and locations like: l…
-
Your HTML looks pretty good, well structured. One thing you should start incorporating is more semantic tags: ` and especially ` there are many more as well. Here is a good article for getting start…
-
(Exceeds Expectations)
Well done on this project! It looks like you have a solid understanding of the display and positioning of elements on a page. And keep up the good work on proper indenting an…
-
https://github.com/LKarnai/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L116-L118
Not a huge deal, but `` tag content is usually kept inline structurally, regardless of the length …
-
The structure of the html and css is correct. Most of the design passed successfully. You are also missing the footer section. Some background colors are also missing. Each section should alternate be…
-
(Meets Expectations)
Nice job on this project! It looks like you have a solid understanding of how HTML and CSS work together for display of content. You were able to recreate all the main componen…
-
Pourquoi faire qqchose d'incompatible avec Windows ? Après une 1h de course après le code, j'ai finalement compris que outre types.py qui est une mauvaise idée, un package n'est pas compatible avec wi…
-
Your HTML structure and organization is good. One thing you can do now to take it to the next level is to start incorporating more HTML5 semantic tags. Right now with all the divs it can be hard to un…