-
@mai-soup I enjoy your comment on the calc of maxAge in
`app.js` in your backend
```js
cookie: {
secure: process.env.NODE_ENV === 'production',
sameSite: process.env.NODE_ENV === …
-
@echo75 The last two functions are exactly the same and the first is similiar. How would one general function for these look like?
`user.js`
```
reviewsMovie(imdbID) {
const filteredRevi…
-
@echo75 You have a very fine grained sense for domain seperation - keep that up. E.g. the css style seperation of files.
I also like your formatting of the code. It makes it enjoyable and understan…
-
@echo75 What's the purpose of using one call instead of having a click handler for each button?
`WatchListe.vue`
```
About this m…
-
@mai-soup The thing with inline js is - just don't do it. It has so many drawbacks:
- A bad separation of concerns because the view shouldn't know about the logic
- It's hard to read, and even ha…
-
-
@mai-soup To me it seems that `CreateLibraryView.vue` is the brother of `EditLibraryView.vue`, nearly identical even, and could use a component. What's your take on this? 😁
-
@echo75 I assume u need to override certain bootstrap styles. In general using important means there's something wrong in the css styling. I know that sometimes, you have to do it. At that point I try…
-
@echo75 In your `ReviewModal.vue` I found this:
```
async handleReview() {
console.log('review submitted')
await axios.post('http://localhost:3000/reviews', {
imdbID: this.…
-
## Bug Report
schema field definition and comment are inconsistent, including:
### base/pkg/kusion_kubernetes/api
- [ ] admissionregistration/v1
- [ ] apps/v1
- [ ] autoscaling/v1
- …