-
## [L-01] Unspecific Compiler Version Pragma
Avoid floating pragmas for non-library contracts.
While floating pragmas make sense for libraries to allow them to be included with multiple different ve…
-
## No Transfer Ownership Pattern
### description
Recommend considering implementing a two step process where the owner or admin nominates an account and the nominated account needs to call an accept…
-
# C4-001 : PREVENT DIV BY 0
## Impact - LOW
On several locations in the code precautions are taken not to divide by 0, because this will revert the code. However on some locations this isn’t done.…
-
## Why
We would like to increase advisory support for dApp developers on Sapphire/OPL and improve access to confidentiality based on conversations with @CedarMist and @oasisprotocol/documentation
…
-
# C4-001 :Use safeTransfer/safeTransferFrom consistently instead of transfer/transferFrom
## Impact - LOW
## Impact
It is good to add a require() statement that checks the return value of token tr…
-
## no validation of ethAmount
### description
in the function `sellFractions()` there is no validation that there is enough ETH in the vault to exchange for fractional tokens for the _amount that i…
-
## missing checks for zero address
### description
Checking addresses against zero-address during initialization or during setting is a security best-practice. However, such checks are missing in add…
-
# C4-001 : Incompatibility With Rebasing/Deflationary/Inflationary tokens
## Impact - LOW
PrePo protocol do not appear to support rebasing/deflationary/inflationary tokens whose balance changes dur…
-
## [L-01] Upgrade Open Zeppelin contract dependency
An outdated OZ version is used (which has known vulnerabilities, see https://github.com/OpenZeppelin/openzeppelin-contracts/security/advisories).
…
-
# ISSUE LIST
#### C4-001 : Critical changes should use two-step procedure - Non Critical
#### C4-002 : Use safeTransfer/safeTransferFrom consistently instead of transfer/transferFrom - Low
#### C4-00…