-
Extracted from #1103
/smell_detectors/ should only contain smell detectors. Not SmellWarning, not SmellRepository and not SmellConfiguration. It's super confusing that this namespace contain 90% sme…
-
I'd like to approach the "how to validate stuff in source code comments" more structured and analytical just for once ;)
**Requirements for validation:**
1.) Valid smell detector -> we already do th…
-
1.) SmellRepository is **not** a smell repository but instead a **smell detector** repository. PR for this is up in #1104
2.) /smells/ is an extremely misleading name. It should be "smell_detectors" …
-
#1058 made me realize that our docs are still far from perfect. Something like [this](https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md#configuration) might seem good…
-
Now with #1001 merged I'd like to introduce this in all our detector specs.
I have a 7 hour bus ride coming up next Wednesday and that's when I'll start cracking on this one ;)
-
Coming from #1049
-
Follow-up from #993
In basically all of our specs for detectors we check the warnings for the right lines, the right message, the right parameters and so on. Unfortunately we do this in a lot of dif…
-
When `#sniff` returns `nil` instead of `[]`, our tests still pass but we output our please-report-an-exception text. We should either allow `nil` output or fail tests in this case.
I found this with …
-
We have a controller that basically looks like this (simplified)
``` ruby
class UsersController < ApplicationController
before_action :find_user, only: [:edit, :update, :destroy]
def find_user
…
-
We have a facade class that basically looks like this:
``` ruby
class AdminDashboard
def initialize
initialized_recent_items
end
def recent_users
@recent_items.fetch(:user)
end
de…