-
Don't forget to put a favicon! This is the small icon on your browser tab. You can add `` to you `` element. It’s a small detail but helps your website look more complete!
https://github.com/spee…
-
En tant que contributeur à OpenFisca, les noms longs de paramètres ou de chemins menant aux paramètres sont handicapants. Ils :
* Empêchent le clonage du projet sous windows (cf. #819)
* Complexifie…
-
![colmar_academy1](https://user-images.githubusercontent.com/5844161/36998848-303b2b96-2073-11e8-874d-9f782c950fdf.png)
You have padding pushback in some of the inner divs. It will most likely g…
-
Excellent job commenting your HTML file!
https://github.com/zhikyang/colmar-academy/blob/51515778d80b0103a4e49119012dbfa357d3c036/index.html#L34
-
https://github.com/Hanshimoto/Colmar-Academy/blob/master/index.html#L2-L236
Your HTML is nicely organized/structured, and you generally followed good code practices such as indentation, readability…
-
-
Great job adding CSS comments to your file! They significantly improve the readability of your code.
https://github.com/zhikyang/colmar-academy/blob/51515778d80b0103a4e49119012dbfa357d3c036/resour…
-
You missed the semi-colon in this block and didn't put the width in a new line here: https://github.com/Ray1016/Colmar-Academy/blob/master/resources/css/style.css#L221-L223
You also have an empty b…
-
Grade: Exceeds Expectations
Summary:
Gerardo, well done on your capstone project! It shows that you know how to apply CSS efficiently to various sections, know how to structure your files correctl…
-
When adding symbols such as the ampersand symbol to a site, it is best practice to add them via their [entity reference](https://developer.mozilla.org/en-US/docs/Glossary/Entity).
For example, we'…