-
In functions in BinInterface, there is a comment that says
> @param {number} binIndex - index associated with the bin, the index may range from 0 to numberOfBins-1
But the assertions in the function…
-
https://github.com/phetsims/scenery-phet/issues/278 identified code related to "color profiles" that had been copy-pasted in at least 4 places.
In https://github.com/phetsims/scenery-phet/issues/27…
-
*NOTE! Prior to doing a code review, copy this checklist to a GitHub issue for the repository being reviewed.*
PhET code-review checklist
=============
**Build and Run Checks**
- [x] Does th…
-
In PlinkoProbabilityIntroModel, PlinkoProbabilityIntroModel, and PlinkoProbabilityLabView, anonymous functions are added to balls as they are created. For example
``` js
//'exited' is triggered when…
-
Found while working on #25. When running a fuzz test, it is possible to call on the image width before it has been loaded. The following line is meant to catch this:
``` js
// Slight chance t…
-
@ariel-phet asked me to code review unit-rates. OK if this happens after @schmitzware has finished his contract. The idea is that I will review and just make any changes that need to be done, rather …
-
At today's developer meeting, @pixelzoom said the primary features he wants from PropertySet are: (a) ease of creating a group of Properties and (b) resetting them as a group.
Whenever we dynamically…
-
Seed random is in 2.4.2 and we are at 2.2. The latest version is MIT instead of BSD, which seems nice (matches the license of most of our other dependencies).
I'm thinking of updating this now while…
-
Below is a list of all "active repos" (taken from chipper).
**Note**
I have been changing Summer 2015 Redeploy to "task:S2015R" #5319e7
(might need to change this name to not confuse with "tasks")
…
-
As an alternative to https://github.com/phetsims/tasks/issues/435 (require.js-based) or https://github.com/phetsims/tasks/issues/431 (eslint-based) for checking the namespacing of https://github.com/p…